Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiate ErrorException from GracefullTerminationException #397

Open
lewart opened this issue Sep 30, 2021 · 1 comment
Open

Differentiate ErrorException from GracefullTerminationException #397

lewart opened this issue Sep 30, 2021 · 1 comment

Comments

@lewart
Copy link

lewart commented Sep 30, 2021

In our application we initialize the CAS Client together with calling CAS_GracefullTerminationException::throwInsteadOfExiting() method and then we handle exceptions in our own fashion.

Right now the same exception CAS_GracefullTerminationException is used when the library ends its work and when there is a real error reported by a phpCAS::error() method.

I think it would be helpful for the integrators, to use a different exception for errors reported in the phpCAS::error() method.

@jfritschi
Copy link
Contributor

Sounds like a good idea. We will be happy to receive a pull request if you already have a patch in place ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants