✨ Allow the usage of built-in input to be optional #19
Conversation
Added the prop strengthMeterOnly to toggle the visibily of the input that's already inside the PasswordStrengthMeter component. This will allow users to use their own input element. For this to work both the user's input element and the password component must bound v-model to the same variable.
|
It would be nice to see what test actually failed so that I can fix it quickly. Also the only test that I'm seeing is the Hello.spec.js
As I commented on the currently opened Issue #18 Add unit tests, I'll be more than happy to help with those if someone writes down the components desired behavior. I really like this library and will use it in production. |
|
Cool thanks for this! Yeah it's only the default test. If I find some time I will add |
|
@apertureless I'll add the example this weekend. |
|
@devsarmico reminder |
|
@devsarmico Hey! Really appreciate this change and I would like to use it as well. Any chance you are soon working on the requested changes from @apertureless so he can merge it? Cheers! |
Done. @apertureless I've just added the strengthMeterOnly to README.md |
|
@apertureless Hey! Any chance you are merging this? Thank you! |
@jkourou Are you using this component in production? |
|
@devsarmico I am currently building an MVP, but yes this is going to production pretty soon. Anything I should know? :) |
|
Sorry for the delay. Quite busy with work. I'm gonna work this week on some other features too and will be adding tests finally. |
Added the prop strengthMeterOnly to toggle the visibily of the input that's already inside the PasswordStrengthMeter component. This will allow users to use their own input element. For this to work both the user's input element and the password component must bound v-model to the same variable.