feat: Add $attrs to input field #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very cool! Will look the coming days into it! |
raybotha
suggested changes
Feb 6, 2020
Co-Authored-By: Raymond Botha <rabotha42@gmail.com>
|
Yeah I agree @raybotha - I pulled in your change. |
apertureless
approved these changes
Feb 6, 2020
apertureless
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This passes through
$attrsto the<input>element per Issue #25. I removed a bunch of the props that aren't necessary anymore because of it too, as well as added a couple examples to the index.html.It passes linting, but not unit tests - but I couldn't get the unit tests to run before this PR either.
Let me know if there's anything you'd like me to change.