Macro rework #22
Merged
Macro rework #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuejn
approved these changes
Oct 1, 2021
This reworks the macros to 1. Reexport everything they need from narui / narui_core under their own module and use them in the generated macros. 2. Put everything the widget macro generates into the widget module. This on the one hand fixes all the macro import issues and makes non star imports work and on the other hand reduces the global namespace pollution by putting everything into the generated module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reworks the macros to
module and use them in the generated macros.
This on the one hand fixes all the macro import issues and makes non star imports
work and on the other hand reduces the global namespace pollution by
putting everything into the generated module.
(Depends on #15 aswell, so merge this after that)