Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(!) Memory Leak in website demo page #29

Closed
GitSquared opened this issue Aug 10, 2018 · 12 comments
Closed

(!) Memory Leak in website demo page #29

GitSquared opened this issue Aug 10, 2018 · 12 comments
Labels
bug Something isn't working

Comments

@GitSquared
Copy link

I am experiencing a critical memory leak issue when trying to access https://apexcharts.com/javascript-chart-demos/

I'm using Firefox Developer Edition 62.0b15 (64-bit), on Debian 9.5 "Stretch".

Here is a video proof (youtube link). You can clearly see the CPU going crazy at around 15 to 20 seconds in the video, only a few moments after loading the page. Then, the memory starts filling up rapidly, eventually eating through swap space, at that point i have no choice but to kill Firefox to keep my system stable.

I do have a few addons installed on the browser, but i do not believe that they have any impact on the issue.

Is anyone able to reproduce this behavior?

@arkhenstone
Copy link

Yup, tried on two computer, RAM usage gone wild, had to restart my PC. Tried on Firefox Linux and Chrome Windows.

@paulocoghi
Copy link

Is anyone able to reproduce this behavior?

Yes, same issue here. Firefox 62.0b15 (64-bit) (non-developer) on Ubuntu 16.04.5 64bit

@junedchhipa
Copy link
Contributor

junedchhipa commented Aug 10, 2018

@GitSquared
Confirmed the bug.
The memory leak is due to the mixed chart. I disabled each chart one by one and disabling mixed charts made the page responsive. Otherwise, my firefox was also crashing every time I loaded the demo page.

I will investigate the mixed chart rendering, thanks for reporting. Looks like combining all three types - area/line/column doesn't works at the moment for firefox.

You can check the demo page now and see if it still crashes.

@junedchhipa junedchhipa added the bug Something isn't working label Aug 10, 2018
@GitSquared
Copy link
Author

@junedchhipa It's working for me now. Thanks for the quick response. Closing.

@arkhenstone
Copy link

@junedchhipa Dashboard demo has the same problem

@junedchhipa
Copy link
Contributor

@arkhenstone I will check the Dashboard too. Combo chart (line/area/column) seems the main culprit. I will try to fix it quickly so I don't have to go to each and every place to disable Mixed Charts ;)

@GitSquared
Copy link
Author

uh... actually, https://apexcharts.com/javascript-chart-demos/heatmap-charts/ has this issue too... So yeah, i think it's in the lib. @junedchhipa I'm reopening and i'll let you close when you fix the "upstream" issue.

@GitSquared GitSquared reopened this Aug 10, 2018
@junedchhipa
Copy link
Contributor

Ah! ok. No worries, keep it open. I need to do some more testing on firefox, I guess.

@junedchhipa junedchhipa changed the title (!) Memory Leak in website demo page (!) Memory Leak in website demo page- Firefox Aug 10, 2018
@GitSquared
Copy link
Author

GitSquared commented Aug 10, 2018

I believe @arkhenstone reported this issue to also happen in Chrome, nah?

Tried on Firefox Linux and Chrome Windows.

Is this still true or is this issue Firefox-specific?

@junedchhipa
Copy link
Contributor

Ah! right. If the same problem persists in Chrome as well, then this is not browser specific. Reverting title change

@junedchhipa junedchhipa changed the title (!) Memory Leak in website demo page- Firefox (!) Memory Leak in website demo page Aug 10, 2018
@junedchhipa
Copy link
Contributor

I have fixed the issues which were crashing Firefox when viewing demo pages.

@arkhenstone can you please test the demo page as well as the dashboards?
@GitSquared can't reproduce the "heatmap" issue in firefox/chrome. Can you please test again and if error persists, give more info?

Thanks

@GitSquared
Copy link
Author

@junedchhipa Everything's working all right. Tested pretty much every link accessible from the demo homepage. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants