Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few issues since upgrading from 2.0.0 #23

Closed
guyzk opened this issue Dec 1, 2019 · 5 comments
Closed

A few issues since upgrading from 2.0.0 #23

guyzk opened this issue Dec 1, 2019 · 5 comments

Comments

@guyzk
Copy link

guyzk commented Dec 1, 2019

Hi!

A few issues since upgrading from 2.0.0

  1. showChartValuesOutside: The are not totally outside, they are partially on the chart which in my opinion doesn't look as good
  2. Legend position that was added looks bad on RTL languages.
    a) It is not aligned to the start of the container
    b) There is not enough padding between the chart and the legends
    I believe that it will be better to have LegendPosition.start and LegendPosition.end instead of left and right.
    Please test on a device with and RTL language.

Thanks for this great package. Hope you could get to fixing these issues soon.

@apgapg
Copy link
Owner

apgapg commented Dec 2, 2019

Thanks for such descriptive info. Will definetly look into it and revert

@guyzk
Copy link
Author

guyzk commented Dec 11, 2019

Thanks for such descriptive info. Will definetly look into it and revert

Hi,
I there any estimation for a fix? My app has several languages 2 of which are RTL and this is critical for me.
Thanks!

@apgapg
Copy link
Owner

apgapg commented Dec 11, 2019

Sorry it just slipped from my mind. Will fix up tomorrow for sure

@guyzk
Copy link
Author

guyzk commented Dec 31, 2019

Any updates?

@apgapg
Copy link
Owner

apgapg commented Sep 5, 2020

All of these are fixed on master branch. Check them LIVE https://apgapg.github.io/pie_chart/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants