Ensure that indexes are retained across reloads #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comparison between services should happened to both underlying indexes, not the wrapped index.
|
I believe this is ready to be merged. |
aphyr
added a commit
that referenced
this pull request
Jun 21, 2014
Ensure that indexes are retained across reloads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
service/equiv?check for a wrapped index currently tries to compare the underlying index with a wrapped index and fails, causing the index to be swapped out.This pull request introduces a
WrappedIndexprotocol to allow a wrapped index to have access to the underlying index of another.I wasn't really clear what the idiomatic way to solve this was, so I just took a shot. Please let me know if there's a cleaner way to do this.
This fixes #405.