send Varnish BAN requests with smaller headers

[jocel1]

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
License	MIT

The idea of this PR is to split the iris in several smaller chunks to avoid the "400 Request Header Or Cookie Too Large" on Varnish when the iris contains a large amount of elements.
CHUNK_SIZE is currently hardcoded, but if this could be controlled as a YAML config parameter, it would be even better.

[soyuka]

Is there a limit on varnish? How did you come up with the value 100?

Nice improvement!

[bastnic]

FYI, there is a chunk made in FosHTTPCache https://github.com/FriendsOfSymfony/FOSHttpCache/blob/master/src/ProxyClient/Varnish.php#L84 and there is a method dedicated to calculate how much tags fits in the http header : https://github.com/FriendsOfSymfony/FOSHttpCache/blob/master/src/ProxyClient/HttpProxyClient.php#L137

[jocel1]

@soyuka it's a really conservative value, but default values in Varnish are not that big (you have by default http_req_hdr_len=8k and http_req_size=32k in Varnish, but even with http_req_size=64k & http_req_hdr_len=4096k I was still experiencing 400 Bad Request issues).

[jocel1]

@bastnic thanks for the tips, this looks great! I'll check if I can improve this PR using the same kind of computation

[dunglas]

👍 on my side! Copying (and crediting) the method from FOSHttpCache looks like a good idea. Could you also fix the PHPStan issue please?

[jocel1]

@dunglas changes done, adding a yaml config variable to set the max_header_length supported by the server + tests

[jocel1]

Hi @dunglas , any plan to merge this one ? :)

[Cocray]

Hi @dunglas , any plan to merge this one ? :)

Hello there! Should we have a release date for this feature? It's something we're waiting with excitement :)

[jocel1]

Hi there! Any update on this one?

[teohhanhui]

phpstan failure not related.

[teohhanhui]

Thanks @jocel1! 🎉 🚀