Add possibility to specify a url generation strategy #3198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antograssiot
force-pushed
the
url-generation-strategy
branch
2 times, most recently
from
13a87c3
to
d457297
Compare
teohhanhui
reviewed
Oct 20, 2019
antograssiot
force-pushed
the
url-generation-strategy
branch
from
d457297
to
f91c039
Compare
teohhanhui
reviewed
Oct 21, 2019
antograssiot
force-pushed
the
url-generation-strategy
branch
2 times, most recently
from
1384f52
to
156a8df
Compare
antograssiot
force-pushed
the
url-generation-strategy
branch
from
156a8df
to
6cd53cd
Compare
apply absolute url to all generated URLs/IRIs Allow passing an url generation strategy instead of a bool Switch to a resource attribute to manage URL generation strategy
dunglas
force-pushed
the
url-generation-strategy
branch
from
6cd53cd
to
1000107
Compare
|
Thank you very much @mab05k @antograssiot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took all the commits of the excellent work of @mab05k in #3084 (and rebasing on master) and added a commit on top of it to propose a similar approach to #2708
I'm still not sure it is better, or if we need to support this instead of the simpler boolean option but at least we can choose.