Implement ApiProperty security attribute #3503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GregoireHebert
force-pushed
the
use-api-property-for-attribute-acl-computation
branch
from
2692611
to
6e93c26
Compare
GregoireHebert
force-pushed
the
use-api-property-for-attribute-acl-computation
branch
from
6e93c26
to
676585c
Compare
chalasr
approved these changes
Apr 21, 2020
|
Thank you very much @fredericbarthelet @GregoireHebert, that's a great addition! Could you add a docs entry too please? |
4 tasks
|
@dunglas the Doc PR is already prepared api-platform/docs#1000 :) |
GregoireHebert
deleted the
use-api-property-for-attribute-acl-computation
branch
Toflar
reviewed
Jan 19, 2021
| $propertyMetadata = $this->propertyMetadataFactory->create($context['resource_class'], $attribute, $options); | ||
| $security = $propertyMetadata->getAttribute('security'); | ||
| if ($this->resourceAccessChecker && $security) { | ||
| return $this->resourceAccessChecker->isGranted($attribute, $security); |
There was a problem hiding this comment.
Shouldn't this be $context['resource_class'] instead of $attribute as first parameter and why don't we pass object as $extraVariables like in the DenyAccessListener?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues #3227