Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 3770 #3820

Merged
merged 6 commits into from Nov 18, 2020
Merged

Fix 3770 #3820

merged 6 commits into from Nov 18, 2020

Conversation

TheCrealm
Copy link
Contributor

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Original PR #3770
License MIT
Doc PR none

This PR implements the @ignore annotation. Original PR: #3370

@TheCrealm
Copy link
Contributor Author

TheCrealm commented Nov 8, 2020 •
edited

By fixing this, i discovered that the @ignore annotation was introduced with symfony 5.1.
Because of that, this will always fail for php7.1 right now.

(Happy first pr noises)

@soyuka
Copy link
Member

soyuka commented Nov 9, 2020

May you add a unit test?

@TheCrealm
Copy link
Contributor Author

Is this ok? @soyuka
i looked at the other tests to figure out how to do it. At the end its covered :)

soyuka
soyuka approved these changes Nov 17, 2020
View reviewed changes
Copy link
Member

@soyuka soyuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, thanks for taking this over!

@soyuka soyuka mentioned this pull request Nov 17, 2020
Closed
@soyuka soyuka merged commit 347a095 into api-platform:master Nov 18, 2020
@lucasgranberg
Copy link
Contributor

lucasgranberg commented Dec 15, 2020 •
edited

We are discussing reverting this change at api-platform/api-platform#1566.

What do people involved with this change think of that? The other option would be to do this separately for schema generation.

@lucasgranberg lucasgranberg mentioned this pull request Dec 16, 2020
Closed
meyerbaptiste added a commit to meyerbaptiste/core that referenced this pull request Dec 16, 2020
@meyerbaptiste
Revert "Serializer: Support ignore annotation (api-platform#3820)"
067c709 
This reverts commit 347a095.
@meyerbaptiste meyerbaptiste mentioned this pull request Dec 17, 2020
Merged
meyerbaptiste added a commit to meyerbaptiste/core that referenced this pull request Dec 18, 2020
@meyerbaptiste
Revert "Serializer: Support ignore annotation (api-platform#3820)"
85fb81c 
This reverts commit 347a095.
meyerbaptiste added a commit to meyerbaptiste/core that referenced this pull request Dec 21, 2020
@meyerbaptiste
Revert "Serializer: Support ignore annotation (api-platform#3820)"
0e92f67 
This reverts commit 347a095.
meyerbaptiste added a commit to meyerbaptiste/core that referenced this pull request Jan 4, 2021
@meyerbaptiste
Revert "Serializer: Support ignore annotation (api-platform#3820)"
589c304 
This reverts commit 347a095.
soyuka added a commit that referenced this pull request Jan 21, 2021
@meyerbaptiste @soyuka
Add the @ignore annotation support (#3910)
4f4efc3 
* Revert "Serializer: Support ignore annotation (#3820)"

This reverts commit 347a095.

* Add the ＠Ignore annotation support

* Try to fix tests

* Fix subresources

Co-authored-by: soyuka <soyuka@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soyuka soyuka soyuka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@TheCrealm @soyuka @lucasgranberg @TNAJanssen