Throw an error when no identifier is defined #3871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
soyuka
commented
Dec 2, 2020
soyuka
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | kinda |
| Deprecations? | no |
| Tickets | |
| License | MIT |
| Doc PR | api-platform/docs#... |
soyuka
force-pushed
the
fix/no-identifiers
branch
2 times, most recently
from
0947f15
to
a89b405
Compare
dunglas
requested changes
Dec 2, 2020
soyuka
force-pushed
the
fix/no-identifiers
branch
from
a89b405
to
167e92f
Compare
kayue
added a commit
to kayue/Sylius
that referenced
this pull request
Jan 23, 2021
Caused by this change api-platform/core#3871
| @@ -57,6 +57,10 @@ public function getIdentifiersFromResourceClass(string $resourceClass): array | |||
| } | |||
| } | |||
|
|
|||
| if (!$identifiers) { | |||
| throw new RuntimeException(sprintf('No identifier defined "%s". You should add #[\ApiPlatform\Core\Annotation\ApiProperty(identifier: true)]" on the property identifying the resource."', $resourceClass)); | |||
There was a problem hiding this comment.
What do you think about
- No identifier defined "%s".
+ No identifier defined in "%s".I mean, "in" is missed from my point of view
pamil
added a commit
to Sylius/Sylius
that referenced
this pull request
Jan 26, 2021
This PR was merged into the 1.8 branch. Discussion ---------- Caused by this change api-platform/core#3871 | Q | A | --------------- | ----- | Branch? | 1.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | api-platform/core#3871 | License | MIT Commits ------- 5a7bc59 Fix no identifier defined error in ApiPlatform 2.6
pamil
pushed a commit
to Sylius/SyliusApiBundle
that referenced
this pull request
Jan 26, 2021
Caused by this change api-platform/core#3871
|
This new exception seems to break POST/PUT endpoints that use a DTO without id as the resource. Is that intended? If so, what are the alternatives? |
|
It should not break unless your DTO is a resource. Please open an issue and provide a reproducer I definitely want to check this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.