[GraphQL] Fix FieldsBuilder not always fully unwrapping a type before deciding if a resolver is needed.
#4251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello David, thanks for the PR.
|
DavidBennettUK
force-pushed
the
graphql-fieldsbuilder-wrapped-type
branch
from
79d068f
to
00a17ec
Compare
|
@alanpoulain Thanks, all done 👍 |
… deciding if a resolver is needed.
alanpoulain
force-pushed
the
graphql-fieldsbuilder-wrapped-type
branch
from
00a17ec
to
8ef71c2
Compare
alanpoulain
approved these changes
Apr 27, 2021
|
Thank you @DavidBennettUK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
FieldsBuildernot using the recursive version ofgetWrappedType. Without this, if the type is wrapped in bothNonNulland thenListOfType, thenListOfTypeis returned instead of the actual type of the list items - which I think was the original intention of this code, as it's trying to decide if the base type needs a special resolver. For example, a non-null list of non-null strings ([String!]!) will now correctly returnStringas the wrapped type with this fix. This means that simple arrays such as this, which are already deserialized by the Symfony deserializer and therefore do not need to use a special resolver, can now work.