fix(test): add withOptions to our HttpClient implementation #4282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyuka
force-pushed
the
fix/http-client-depreciation
branch
2 times, most recently
from
8d3dd57
to
93e7cb5
Compare
| @@ -51,7 +51,7 @@ public function applyToCollection(array $requestBody, string $resourceClass, ?st | |||
|
|
|||
| foreach ($resourceFilters as $filterId) { | |||
| if ($this->filterLocator->has($filterId) && is_a($filter = $this->filterLocator->get($filterId), $this->getFilterInterface(), true)) { | |||
There was a problem hiding this comment.
For PHPStan's error about class-string<object>|object, wouldn't this be better?
Suggested change
| if ($this->filterLocator->has($filterId) && is_a($filter = $this->filterLocator->get($filterId), $this->getFilterInterface(), true)) { | |
| if ($this->filterLocator->has($filterId) && is_a($filter = $this->filterLocator->get($filterId), $this->getFilterInterface())) { |
(and revert the //@phpstan-ignore-line below)
soyuka
force-pushed
the
fix/http-client-depreciation
branch
from
93e7cb5
to
7f4b2cd
Compare
18 tasks
LoicBoursin
pushed a commit
to LoicBoursin/core
that referenced
this pull request
Aug 18, 2021
…form#4282) * fix(test): add withOptions to our HttpClient implementation * chore(phpstan): fix false positives
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.