Fix openapi normalization #4325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
relates to #4319 |
tassilogroeper
force-pushed
the
fix-openapi-normalization
branch
from
011e06d
to
b630e14
Compare
dunglas
requested changes
Jun 15, 2021
tassilogroeper
force-pushed
the
fix-openapi-normalization
branch
from
9bb64db
to
9b54731
Compare
alanpoulain
reviewed
Jun 23, 2021
tassilogroeper
force-pushed
the
fix-openapi-normalization
branch
from
9b54731
to
46b6351
Compare
@alanpoulain done |
|
Thank you @pheadeaux. |
|
@dunglas @pheadeaux can someone publish this tag? is not yet available :( i manually install 2.6 branch |
vincentchalamon
pushed a commit
to vincentchalamon/core
that referenced
this pull request
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in issue #4318 the function recursiveClean does nest one more time and fails, if an ApiResource has a property named
paths. Updated tests to reproduce the failing parts.This is version 2, a more general approach, since the logic inside
\ApiPlatform\Core\OpenApi\Serializer\OpenApiNormalizer::recursiveCleanwas doing two things:extensionPropertieskeys in a recursion andschemasandpathsproperties of the OpenApi objectSo why not do the sorting in the Object generation directly and fix the double nested
pathsissue with the normalizing call itself.Idea is taken from: Using Callbacks to Serialize Properties with Object Instances