fix: use asset_package for all assets #4470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkrauser
changed the title
alanpoulain
reviewed
Sep 24, 2021
| @@ -11,7 +11,7 @@ | |||
|
|
|||
| declare(strict_types=1); | |||
|
|
|||
| namespace ApiPlatform\Core\GraphQl\Action; | |||
| namespace ApiPlatform\GraphQl\Action; | |||
There was a problem hiding this comment.
Why are you changing the namespace?
There was a problem hiding this comment.
Oh, sorry. Must have been some hickup in my IDE. I'll reverse that
alanpoulain
reviewed
Sep 24, 2021
alanpoulain
approved these changes
Sep 24, 2021
|
Thanks @mkrauser. |
Thank you for your awesome work @alanpoulain! |
vincentchalamon
pushed a commit
to vincentchalamon/core
that referenced
this pull request
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the configurable asset_path for every asset, not just in SwaggerUi, also in Graphiql and GraphQlPlayground