Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Symfony components compatibility to ^6.1 + migrate code to PHP 8.1 + clean code #4851

Merged
merged 14 commits into from Aug 2, 2022
Merged

Fix Symfony components compatibility to ^6.1 + migrate code to PHP 8.1 + clean code #4851

merged 14 commits into from Aug 2, 2022

Conversation

vincentchalamon
Copy link
Contributor

@vincentchalamon vincentchalamon commented Jul 28, 2022 •
edited

  • Remove symfony/* dependencies < 6.1
  • Fix Symfony components compatibility
  • Migrate code to PHP 8.1 (using rector)
  • Clean code
  • Fix CI

@vincentchalamon vincentchalamon self-assigned this Jul 28, 2022
@vincentchalamon vincentchalamon linked an issue Jul 28, 2022 that may be closed by this pull request
Remove support of Symfony < 6.0 in API Platform 3.0 #4850
Closed
@dunglas
Copy link
Member

dunglas commented Jul 28, 2022

We could even upgrade to 6.1.

@vincentchalamon vincentchalamon changed the title Chore/symfony versions Fis Symfony components compatibility + migrate code to PHP 8.1 + clean code Jul 28, 2022
@vincentchalamon vincentchalamon changed the title Fis Symfony components compatibility + migrate code to PHP 8.1 + clean code Fix Symfony components compatibility to ^6.1 + migrate code to PHP 8.1 + clean code Jul 28, 2022
maxhelias
maxhelias reviewed Jul 29, 2022
View reviewed changes
rector.php Outdated Show resolved Hide resolved
@vincentchalamon vincentchalamon force-pushed the chore/symfony-versions branch 4 times, most recently from c0ddf51 to 5babf42 Compare July 29, 2022 13:42
@vincentchalamon vincentchalamon marked this pull request as ready for review July 29, 2022 13:51
@alanpoulain
Copy link
Member

Shouldn't we keep assertSame?

@vincentchalamon vincentchalamon merged commit 30add35 into api-platform:main Aug 2, 2022
@vincentchalamon vincentchalamon deleted the chore/symfony-versions branch August 2, 2022 12:02
@alanpoulain alanpoulain mentioned this pull request Aug 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxhelias maxhelias maxhelias left review comments

@alanpoulain alanpoulain alanpoulain approved these changes

@soyuka soyuka Awaiting requested review from soyuka

@dunglas dunglas Awaiting requested review from dunglas

Assignees

@vincentchalamon vincentchalamon

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove support of Symfony < 6.0 in API Platform 3.0
4 participants
@vincentchalamon @dunglas @alanpoulain @maxhelias