fix(graphql): always allow to query nested resources #5112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanpoulain
reviewed
Nov 3, 2022
src/GraphQl/Metadata/Factory/GraphQlNestedOperationResourceMetadataFactory.php
Outdated
Show resolved
Hide resolved
alanpoulain
reviewed
Nov 3, 2022
alanpoulain
reviewed
Nov 3, 2022
alanpoulain
reviewed
Nov 3, 2022
alanpoulain
reviewed
Nov 3, 2022
alanpoulain
reviewed
Nov 3, 2022
alanpoulain
reviewed
Nov 3, 2022
alanpoulain
reviewed
Nov 3, 2022
| @@ -134,6 +133,7 @@ | |||
| <argument type="service" id="api_platform.pagination" /> | |||
| <argument type="service" id="api_platform.name_converter" on-invalid="ignore" /> | |||
| <argument>%api_platform.graphql.nesting_separator%</argument> | |||
| <argument type="service" id="api_platform.graphql_metadata.resource.metadata_collection_factory" on-invalid="ignore"></argument> | |||
There was a problem hiding this comment.
Suggested change
| <argument type="service" id="api_platform.graphql_metadata.resource.metadata_collection_factory" on-invalid="ignore"></argument> | |
| <argument type="service" id="api_platform.graphql_metadata.resource.metadata_collection_factory" on-invalid="ignore" /> |
alanpoulain
reviewed
Nov 3, 2022
soyuka
force-pushed
the
fix/graphql-nested-resource-operation
branch
3 times, most recently
from
432ff12
to
e38414d
Compare
alanpoulain
reviewed
Nov 4, 2022
| @@ -133,6 +133,7 @@ | |||
| <argument type="service" id="api_platform.pagination" /> | |||
| <argument type="service" id="api_platform.name_converter" on-invalid="ignore" /> | |||
| <argument>%api_platform.graphql.nesting_separator%</argument> | |||
| <argument type="service" id="api_platform.graphql_metadata.resource.metadata_collection_factory" on-invalid="ignore" /> | |||
There was a problem hiding this comment.
I'm not sure if the on-invalid is necessary.
soyuka
force-pushed
the
fix/graphql-nested-resource-operation
branch
from
e38414d
to
2a75c00
Compare
alanpoulain
approved these changes
Nov 4, 2022
1 task
soyuka
added a commit
that referenced
this pull request
Nov 4, 2022
* fix: update yaml extractor test file coding standard (#5068) * fix(graphql): add clearer error message when TwigBundle is disabled but graphQL clients are enabled (#5064) * fix(metadata): add class key in payload argument resolver (#5067) * fix: add class key in payload argument resolver * add null if everything else goes wrong * fix: upgrade command remove ApiSubresource attribute (#5049) Fixes #5038 * fix(doctrine): use abitrary index instead of value (#5079) * fix: uri template should respect rfc 6570 (#5080) * fix: remove @internal annotation for Operations (#5089) See #5084 * fix(metadata): define a name on a single operation (#5090) fixes #5082 * fix(metadata): deprecate when user decorates in legacy mode (#5091) fixes #5078 * fix(graphql): use right nested operation (#5102) * Revert "fix(graphql): use right nested operation (#5102)" (#5111) This reverts commit 44337dd. * fix(graphql): always allow to query nested resources (#5112) * fix(graphql): always allow to query nested resources * review Co-authored-by: Alan Poulain <contact@alanpoulain.eu> * chore: php-cs-fixer update * fix: only alias if exists for opcache preload Fixes api-platform/api-platform#2284 (#5110) Co-authored-by: Liviu Mirea <liviu.mirea@wecodepixels.com> * chore: php-cs-fixer update (#5118) * chore: php-cs-fixer update * chore: php-cs-fixer update * fix(metadata): upgrade script keep operation name (#5109) origin: #5105 Co-authored-by: WilliamPeralta <william.peralta18@gmail.com> * chore: v2.7.3 changelog * chore: v3.0.3 changelog Co-authored-by: helyakin <CourcierMarvin@gmail.com> Co-authored-by: ArnoudThibaut <thibaut.arnoud@gmail.com> Co-authored-by: davy-beauzil <38990335+davy-beauzil@users.noreply.github.com> Co-authored-by: Baptiste Leduc <baptiste.leduc@gmail.com> Co-authored-by: Xavier Laviron <norival@users.noreply.github.com> Co-authored-by: Alan Poulain <contact@alanpoulain.eu> Co-authored-by: Liviu Cristian Mirea-Ghiban <contact@liviucmg.com> Co-authored-by: Liviu Mirea <liviu.mirea@wecodepixels.com> Co-authored-by: WilliamPeralta <william.peralta18@gmail.com>
alanpoulain
reviewed
Nov 6, 2022
Comment on lines
+54
to
+61
| if (class_exists($resourceClass)) { | ||
| $refl = new \ReflectionClass($resourceClass); | ||
| $attribute = $refl->getAttributes(ApiResource::class)[0] ?? null; | ||
| $attributeInstance = $attribute?->newInstance(); | ||
| if ($filters = $attributeInstance?->getFilters()) { | ||
| $apiResource = $apiResource->withFilters($filters); | ||
| } | ||
| } |
There was a problem hiding this comment.
issue: This should work with XML/YAML too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework of #5102