Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking changes in a patch version #5725

Closed
Aerendir opened this issue Aug 7, 2023 · 0 comments
Closed

Breaking changes in a patch version #5725

Aerendir opened this issue Aug 7, 2023 · 0 comments

Comments

@Aerendir
Copy link
Contributor

Aerendir commented Aug 7, 2023

Closed as I read the two issues related to the PR: I'll first investigate the problem on my app, trying to identify a possible solution.


API Platform version(s) affected: 3.1.13

Hello,
I'm writing to report a violation in the SemVer rules.

The last update, broke a lot of my tests due to breaking changes.

The fix made with PR #5604 actually broke some tests.

The broken tests are of subresource that relied on the fixed bug to work.

Now, for sure my code was relying on a bug to work, but that bug made my code work.

Also if it was a bug, it actually was a feature given the state of the library at the moment of writing that code.

Changing the behavior in a patch release, I think violates the SemVer rules as it completely breaks working code.

I think such a bug should have been fixed in a major version, not in a patch release (nor in a minor one).

Doing this fix a patch release is really dangerous for production applications or for applications that doesn't have a complete test suite: the apps will broke applying a patch release, and this should never happen: this is the exact purpose of SemVer.

Violating it, puts a really high and dangerous risk all applications that use ApiPlatform Core.

WDYT?

@Aerendir Aerendir closed this as completed Aug 7, 2023
@Aerendir Aerendir changed the title Breaking changes in a minor version Breaking changes in a patch version Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant