Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm version bump causing CI failures #1872

Closed
dcroote opened this issue Sep 2, 2023 · 0 comments · Fixed by #1873
Closed

npm version bump causing CI failures #1872

dcroote opened this issue Sep 2, 2023 · 0 comments · Fixed by #1873
Assignees
Milestone

Comments

@dcroote
Copy link
Contributor

dcroote commented Sep 2, 2023

Multiple PRs are failing on the "Build all the Docker containers and push them to Docker Hub" CI step (example 1, example 2). The error is:

#7 [2/8] RUN apk add --update --no-cache git rsync docker $([ $(arch) == "aarch64" ] && echo "python3 make g++") &&     yarn global add npm &&     mkdir -p /root/.cache/hardhat-nodejs/compilers-v2/wasm &&     wget -O /root/.cache/hardhat-nodejs/compilers-v2/wasm/soljson-v0.8.9+commit.e5eed63a.js https://solc-bin.ethereum.org/wasm/soljson-v0.8.9+commit.e5eed63a.js &&     wget -O /root/.cache/hardhat-nodejs/compilers-v2/wasm/list.json https://solc-bin.ethereum.org/wasm/list.json &&     mkdir -p /root/.cache/hardhat-nodejs/compilers-v2/linux-amd64 &&     wget -O /root/.cache/hardhat-nodejs/compilers-v2/linux-amd64/list.json https://solc-bin.ethereum.org/linux-amd64/list.json &&     touch /root/.cache/hardhat-nodejs/compilers-v2/linux-amd64/solc-linux-amd64-v0.8.9+commit.e5eed63a &&     touch /root/.cache/hardhat-nodejs/compilers-v2/linux-amd64/solc-linux-amd64-v0.8.9+commit.e5eed63a.does.not.work
#7 0.206 fetch https://dl-cdn.alpinelinux.org/alpine/v3.17/main/x86_64/APKINDEX.tar.gz
#7 0.354 fetch https://dl-cdn.alpinelinux.org/alpine/v3.17/community/x86_64/APKINDEX.tar.gz
#7 0.615 (1/24) Installing ca-certificates (20230506-r0)
#7 0.633 (2/24) Installing libseccomp (2.5.4-r0)
#7 0.638 (3/24) Installing runc (1.1.5-r2)
#7 0.729 (4/24) Installing containerd (1.6.18-r2)
#7 1.577 (5/24) Installing libmnl (1.0.5-r0)
#7 1.581 (6/24) Installing libnftnl (1.2.4-r0)
#7 1.587 (7/24) Installing iptables (1.8.8-r2)
#7 1.613 (8/24) Installing ip6tables (1.8.8-r2)
#7 1.621 (9/24) Installing tini-static (0.19.0-r1)
#7 1.624 (10/24) Installing device-mapper-libs (2.03.17-r1)
#7 1.632 (11/24) Installing docker-engine (20.10.24-r2)
#7 2.189 (12/24) Installing docker-cli (20.10.24-r2)
#7 2.516 (13/24) Installing docker (20.10.24-r2)
#7 2.525 Executing docker-20.10.24-r2.pre-install
#7 2.532 (14/24) Installing brotli-libs (1.0.9-r9)
#7 2.547 (15/24) Installing nghttp2-libs (1.51.0-r1)
#7 2.551 (16/24) Installing libcurl (8.2.1-r0)
#7 2.562 (17/24) Installing libexpat (2.5.0-r0)
#7 2.566 (18/24) Installing pcre2 (10.42-r0)
#7 2.577 (19/24) Installing git (2.38.5-r0)
#7 2.659 (20/24) Installing libacl (2.3.1-r1)
#7 2.662 (21/24) Installing lz4-libs (1.9.4-r1)
#7 2.666 (22/24) Installing popt (1.19-r0)
#7 2.671 (23/24) Installing zstd-libs (1.5.5-r0)
#7 2.680 (24/24) Installing rsync (3.2.7-r0)
#7 2.691 Executing busybox-1.35.0-r29.trigger
#7 2.696 Executing ca-certificates-20230506-r0.trigger
#7 2.766 OK: 247 MiB in 41 packages
#7 3.014 yarn global v1.22.19
#7 3.074 [1/4] Resolving packages...
#7 4.503 [2/4] Fetching packages...
#7 8.999 error npm@10.0.0: The engine "node" is incompatible with this module. Expected version "^18.17.0 || >=20.5.0". Got "18.14.0"
#7 9.012 error Found incompatible module.

It turns out npm 10.0.0 was released one day ago. Two days ago, when CI passed for a build, npm@9.8.1 was installed:

#7 12.79 success Installed "npm@9.8.1" with binaries

Therefore, this could be solved by either bumping Node.js from 18.14.0 to 18.17.1 throughout the repo (package.json, Dockerfiles, CI env) or changing the docker command to yarn global add npm@^9.8.1. Given we'd like to release the Airnode v0.12.1 patch soon, I'd lean towards the latter, followed by the former for the next Airnode minor release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant