Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support building openresty via openssl which maintained by openresty itself #171

Open
soulbird opened this issue Mar 15, 2022 · 4 comments

Comments

@soulbird
Copy link
Contributor

When we compile openresty, we need to use openssl. When we use openssl dynamic library, we cannot guarantee that the version of openssl officially maintained by openresty is finally used.

@tzssangglass
Copy link
Contributor

where is not used?

I see that some of the scripts use the openresty-opsneel, e.g.:

yum -y install openresty-openssl111-debug-devel openresty-pcre-devel openresty-zlib-devel

@soulbird
Copy link
Contributor Author

build-apisix-base-debug-centos7.sh

I am not centos, maybe we should add in build-apisix-base.sh

@tzssangglass
Copy link
Contributor

I am not centos, maybe we should add in build-apisix-base.sh

build-apisix-base.sh is used by build-apisix-base-debug-centos7.sh

Line 7 in a386c7e

see:

I think the job of specifying the openssl version should be done in build-apisix-base-debug-xxx.sh, e.g. https://github.com/tzssangglass/apisix-build-tools/blob/3bcf4f5bd5773d11f3bbec006396032edb53e706/build-apisix-base-maoos_x86_64.sh#L14

@soulbird
Copy link
Contributor Author

I am not centos, maybe we should add in build-apisix-base.sh

build-apisix-base.sh is used by build-apisix-base-debug-centos7.sh

Line 7 in a386c7e

see:

I think the job of specifying the openssl version should be done in build-apisix-base-debug-xxx.sh, e.g. https://github.com/tzssangglass/apisix-build-tools/blob/3bcf4f5bd5773d11f3bbec006396032edb53e706/build-apisix-base-maoos_x86_64.sh#L14

LGTM. I will do it like this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants