Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add distribution information for rpm #64

Closed
imjoey opened this issue Aug 6, 2021 · 1 comment
Closed

feat: Add distribution information for rpm #64

imjoey opened this issue Aug 6, 2021 · 1 comment

Comments

@imjoey
Copy link
Contributor

imjoey commented Aug 6, 2021 •
edited
Loading

In general, the name of the rpm artifact often contains the distribution of the supported OS. For example, openresty-1.19.3.2-1.el8.x86_64.rpm shows that it's for CentOS 8. While the rpm files for apisix do not contain the distribution information and users may get confused to know which OS the apisix-2.8-0.x86_64.rpm is for.

So it would be great if we could make use of the --rpm-dist flag of fpm to add the distribution of rpm, such as: apisix-2.8-0.el8.x86_64.rpm. Furthermore, this improvement may also allow us to make one rpm artifact for each version of one distribution.

BTW: the 1 is often used as the first release version of one rpm. So do we need to change the current 0 to 1, like: apisix-2.8-1.el8.x86_64.rpm?

Any feedback is welcome. Thanks.
@spacewander
Copy link
Contributor

LGTM

@imjoey imjoey mentioned this issue Aug 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@imjoey @spacewander