Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: reflectToEtcd and PushEvent should be blocking #77

Open
lingsamuel opened this issue Aug 2, 2021 · 0 comments
Open

bug: reflectToEtcd and PushEvent should be blocking #77

lingsamuel opened this issue Aug 2, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@lingsamuel
Copy link
Contributor

lingsamuel commented Aug 2, 2021 •
edited

Assuming there are two events sets coming from the provisoner.

Sending events non-blockingly will result in the second set (with a higher revision) possibly arriving earlier than the first.

To reduce push count, we need to merge events in PushEvent.
@lingsamuel lingsamuel changed the title reflectToEtcd should be blocking bug: reflectToEtcd should be blocking Aug 2, 2021
@lingsamuel lingsamuel added the bug Something isn't working label Aug 2, 2021
@lingsamuel lingsamuel changed the title bug: reflectToEtcd should be blocking bug: reflectToEtcd and PushEvent should be blocking Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lingsamuel