Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unrecognized param #620

Open
abtris opened this issue Mar 24, 2014 · 6 comments
Open

Unrecognized param #620

abtris opened this issue Mar 24, 2014 · 6 comments
Labels

Comments

@abtris
Copy link
Contributor

abtris commented Mar 24, 2014

@Neamar opened apiaryio/snowcrash#90

(not sure i'm posting on right repo, since i'm using API blueprint from @danielgtaylor Aglio)

My API allow for parameters prefixed with "@", for instance "@name=".
However, describing such an endpoint result in the following error:

>> Line 134: ignoring unrecognized list item, expected parameter discussion, e.g. '<parameter name> ... lorem ipsum' (warning code 5)

Where line 134 is:

+ Parameters
    + @meta (optional, string, `John`) ... Full text search on `meta` key.  Replace `meta` with the name of the meta you wish to search on.

However, i believe such a parameter is actually valid HTTP. Would it be possible to improve snowcrash to handle this use case ? (and possibly more exotic charsets).

I tried to HTML escape / encodeURIComponent without success.

@abtris
Copy link
Contributor Author

abtris commented Mar 24, 2014

@Almad commented

I believe this is related to apiaryio/api-blueprint#69

@abtris
Copy link
Contributor Author

abtris commented Mar 24, 2014

@Almad commented

@Neamar I think @ is only allowed as %40. This makes things a bit complicated as we have to decide where and who should encode the special character.

This is currently a bit in limbo. I agree that for users, @ should be allowed as it is, but in case of some characters, it may lead to ambiguous interpretations of a resource.

However, for now, there is a problem with precent-encoded values as well. I do think those should be fixed as well -- in spec as well in snowcrash.

@abtris
Copy link
Contributor Author

abtris commented Mar 26, 2014

@Neamar commented

Ok. So for now, there is no workarounds ? :(

On Mon, Mar 24, 2014 at 3:24 PM, Almad notifications@github.com wrote:

@Neamar https://github.com/Neamar I think @ is only allowed as %40.
This makes things a bit complicated as we have to decide where and who
should encode the special character.

This is currently a bit in limbo. I agree that for users, @ should be
allowed as it is, but in case of some characters, it may lead to ambiguous
interpretations of a resource.

However, for now, there is a problem with precent-encoded values as well.
I do think those should be fixed as well -- in spec as well in snowcrash.

Reply to this email directly or view it on GitHubhttps://github.com/apiaryio/snowcrash/issues/90#issuecomment-38449993
.

@abtris
Copy link
Contributor Author

abtris commented Apr 2, 2014

@zdne commented

@Neamar

This is a good question

Currently a parameter identifier is expected to conform to:

#define PARAMETER_IDENTIFIER "([[:alnum:]_.-]+)"

But as of RFC 6570 variables it should be:

varname  =  varchar *( ["."] varchar )
varchar    =  ALPHA / DIGIT / "_" / pct-encoded

This is a bug and should be fixed in Snow Crash. An explicit note on URI template variables might be added to API Blueprint spec (most likely 1B).

@abtris
Copy link
Contributor Author

abtris commented Jul 9, 2014

@abtris
Copy link
Contributor Author

abtris commented Jul 24, 2014

@zdne commented

To be addressed with apiaryio/snowcrash#61

@abtris abtris added the bug label Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant