Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match wagmi API #105

Closed
fracek opened this issue May 9, 2022 · 1 comment
Closed

Match wagmi API #105

fracek opened this issue May 9, 2022 · 1 comment

Comments

@fracek
Copy link
Contributor

fracek commented May 9, 2022

The new version of wagmi changed their API and now it's closer to the API in starknet-react.
From a discussion with @Pet3ris we started thinking about aligning our API to wagmi's since now the differences are minuscule.

The changes will be:

  • Rename hooks to follow wagmi's names
  • Rename hooks return values to match wagmi's. Most return values already match them
  • Change the hooks parameters to have positional arguments over keyword arguments like we do now
  • Add shims to map the current api with the new api so that the transition will be smooth

The semantics of the library will not change

@ltoussaint
Copy link
Contributor

Very interesting.
Maybe could be a good idea to split this "refactoring" into several issues, it will help :

  • to get the list of changes to do
  • for people to know exactly how to help on small features
  • to open discussion on specific features

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants