Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-use the File, Config field, and file-related validators from flask-marshmallow #540

Closed
4 tasks
greyli opened this issue Feb 5, 2024 · 1 comment
Closed
4 tasks

Re-use the File, Config field, and file-related validators from flask-marshmallow #540

greyli opened this issue Feb 5, 2024 · 1 comment
Labels
improvement

Comments

@greyli
Copy link
Member

greyli commented Feb 5, 2024

Since we have migrated the File, Config field, and file-related validators to flask-marshmallow (marshmallow-code/flask-marshmallow#280), the next step will be to remove these fields from APIFlask and import them from flask-marshmallow directly.

Also, we need to pin flask-marshmallow to >= 1.0.0 version.

  • Remove these fields
  • Update docs
  • Update changelog
  • Pin flask-marshmallow version
@greyli greyli mentioned this issue Feb 5, 2024
Merged
@uncle-lv uncle-lv mentioned this issue Feb 18, 2024
Merged
@greyli
Copy link
Member Author

greyli commented Feb 22, 2024

Fixed in #543

@greyli greyli closed this as completed Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@greyli