Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apify.call() is lacking timeoutSecs and contains some weird backwards compatibility hacks #143

Closed
jancurn opened this issue Aug 10, 2018 · 2 comments
Closed

Apify.call() is lacking timeoutSecs and contains some weird backwards compatibility hacks #143

jancurn opened this issue Aug 10, 2018 · 2 comments
Labels
bug Something isn't working.

Comments

@jancurn
Copy link
Member

jancurn commented Aug 10, 2018

The timeoutSecs options should be consistent with timeout param in apify-client-js as well as Apify API. Check that waitSecs usage is correct and remove the old backwards compatibility hacks. Write this to changelog as breaking change!
@jancurn jancurn added the bug Something isn't working. label Aug 10, 2018
@jancurn
Copy link
Member Author

jancurn commented Oct 31, 2018

@mtrunkat Maybe we could fix this with the new Apify.callTask development.

@mtrunkat
Copy link
Member

mtrunkat commented Nov 2, 2018

Done.

@mtrunkat mtrunkat closed this as completed Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mtrunkat @jancurn