feat: allow disabling storage persistence #1539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
B4nan
reviewed
Sep 14, 2022
B4nan
reviewed
Sep 14, 2022
B4nan
approved these changes
Sep 15, 2022
|
Looking good, just the test is broken. Feel free to merge if the CI is green (maybe also try running e2e tests to be sure, but we dont need to wait for the platform ones to finish). |
|
Test was broken because I forgot to update it when I renamed the option 😬 |
|
Now it seems to be timeouting |
B4nan
reviewed
Sep 15, 2022
|
|
||
| expect(directoryFiles).toHaveLength(0); | ||
| // We check that reading the directory for the store throws an error, which means it wasn't created on disk | ||
| await expect(() => readdir(expectedPath)).rejects.toThrow(); |
There was a problem hiding this comment.
FYI the argument does not have to be callback (as long as its async), this should work the same:
Suggested change
| await expect(() => readdir(expectedPath)).rejects.toThrow(); | |
| await expect(readdir(expectedPath)).rejects.toThrow(); |
At least that is how I use it, if there is a reason to prefer the callback approach, let me know :]
B4nan
changed the title
B4nan
deleted the
feat/allow-disabling-writing-to-disk-in-memory-storage
branch
|
This looks almost like an undeclare dependency or something... Only platform tests fail.
edit: or more like that test dont have the browser pool package linked properly? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves the request in #1533