feat(core): add RequestQueue.addRequestsBatched() that is non-blocking
#1996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the `BasicCrawler.addRequests()` was the only place where we're handling adding the requests in non-blocking manner. This logic is now moved to the `RequestQueue.addRequestsBatched()` method. This method now also correctly handles the `requestsFromUrl` option, meaning it can be also used with the `BasicCrawler.addRequests()` shortcut. Moreover, the batching is now configurable via `batchSize` and `waitBetweenBatchesMillis` options. Closes #1995
vladfrangu
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
BasicCrawler.addRequests()was the only place where we're handling adding the requests in non-blocking manner. This logic is now moved to theRequestQueue.addRequestsBatched()method.This method now also correctly handles the
requestsFromUrloption, meaning it can be also used with theBasicCrawler.addRequests()shortcut. Moreover, the batching is now configurable viabatchSizeandwaitBetweenBatchesMillisoptions.Closes #1995