feat: exceeding maxSessionRotations calls failedRequestHandler #2029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any request exceeding the
maxSessionRotationslimit currently kills the crawler. This was intended for early exit on too many hard proxy errors, but proved to be somewhat confusing for users usingretryOnBlocked(any page that the crawler cannot access due to bot protection kills the run).With this PR, the requests that cross the limit of
maxSessionRotationsnow get processed withfailedRequestHandler. Not sure if this is breaking (definitely might confuse a dev or two), but it's in line with how the crawlers worked before theSessionErrorupdate (so... it's actually reverting the hidden breaking change?)Closes #2028