Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add warning when we detect use of RL and RQ, but RQ is not provided explicitly #2115

Merged
merged 1 commit into from Oct 4, 2023
Merged

fix: add warning when we detect use of RL and RQ, but RQ is not provided explicitly #2115

merged 1 commit into from Oct 4, 2023

Conversation

B4nan
Copy link
Member

@B4nan B4nan commented Oct 4, 2023

Closes #1773

@B4nan B4nan added the adhoc Ad-hoc unplanned task added during the sprint. label Oct 4, 2023
@github-actions github-actions bot added this to the 73nd sprint - Tooling team milestone Oct 4, 2023
@github-actions github-actions bot added t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics. labels Oct 4, 2023
@B4nan B4nan merged commit 6fb1c55 into master Oct 4, 2023
7 checks passed
@B4nan B4nan deleted the warn-rq-rl branch October 4, 2023 13:01
mvolfik
mvolfik reviewed Oct 4, 2023
View reviewed changes
Copy link
Contributor

@mvolfik mvolfik left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The warning probably should also be added to enqueueLinks https://github.com/apify/crawlee/pull/2115/files#diff-3606a49356303bfa2bfed957bc81701e3d45d4cdafd4d5182685ef826c93b63fL1142-L1144

@B4nan
Copy link
Member Author

B4nan commented Oct 4, 2023

enqueueLinks uses the crawler.getRequestQueue() method, where this is handled, so it should be fine. Or did I miss something?

@mvolfik
Copy link
Contributor

mvolfik commented Oct 4, 2023

Oh, right, sorry. I was thinking that I would fix this by adding the warning to addRequests, and didn't realize you added the warning directly to the getRequestQueue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvolfik mvolfik mvolfik left review comments

@vladfrangu vladfrangu vladfrangu approved these changes

Assignees

@B4nan B4nan

Labels
adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.
Projects
None yet
Milestone
73nd sprint - Tooling team
Development

Successfully merging this pull request may close these issues.

RequestList + crawler.addRequests finishes with unfinished queue after resurrect
3 participants
@B4nan @mvolfik @vladfrangu