fix: ES2022 build compatibility and move to NodeNext for module #2258
Conversation
github-actions
bot
added
the
t-tooling
| @@ -1,7 +1,8 @@ | |||
| { | |||
| "extends": "@apify/tsconfig", | |||
| "compilerOptions": { | |||
| "module": "ES2022", | |||
| "module": "NodeNext", | |||
| "moduleResolution": "NodeNext", | |||
There was a problem hiding this comment.
Afaik this is implicit with module: nodenext. Also, isnt this breaking?
There was a problem hiding this comment.
It's not, if we specify module, it'll throw unless we also specify moduleResolution
Its not... breaking per say, although some older modules might throw compile errors when import-ed... But we should be moving away from compiling to ES20XX and compile to Node16/Next anyways (or bring in a bundler that isn't tsc for it)
There was a problem hiding this comment.
I actually saw the opposite behaviour in mikroorm, but i think it was a ts bug in validation. But i do remember reading in docs that this is actually inferred (and it does work that way on my end, i get dynamic imports in the compiled files by only specifying module)
There was a problem hiding this comment.
Funky, I tried changing just module in our templates and then ran tsc and it threw an immediate error that moduleResolution must also be set to it 😅
There was a problem hiding this comment.
Well, programming is sometimes weird :) feel free to merge this, even if it would be duplicating things, its fine
vladfrangu
deleted the
fix/move-templates-to-nodenext-module-and-installing-missing-types-pkg
branch
Closes #2257