fix: declare missing dependencies on csv-stringify
and fs-extra
#2326
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a quick win where this is the only thing that prevents crawlee from running via yarn pnp out of the box. the basic-crawler package was using two dependencies not specified in its package.json (
csv-stringify
andfs-extra
) as also mentioned by runningyarn dlx @yarnpkg/doctor ./packages/basic
:there's the
no-extraneous-dependencies
rule fromeslint-plugin-import
that helps to address these kinds of problems but i can see it's been explicitly disabled in the main.eslintrc.json
file so i haven't opted to re-enable it here.