Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

querySelector should be propagated to all crawling contexts #2349

Closed
janbuchar opened this issue Feb 21, 2024 · 2 comments
Closed

querySelector should be propagated to all crawling contexts #2349

janbuchar opened this issue Feb 21, 2024 · 2 comments
Assignees
@janbuchar
Labels
t-tooling Issues with this label are in the ownership of the tooling team.

Comments

@janbuchar
Copy link
Contributor

As mentioned by @B4nan in #2316
@janbuchar janbuchar added the t-tooling Issues with this label are in the ownership of the tooling team. label Feb 21, 2024
@janbuchar
Copy link
Contributor Author

@B4nan do we still want to go through with this? Doesn't waitForSelector and parseWithCheerio work just as fine?

@B4nan
Copy link
Member

B4nan commented Jun 28, 2024

Yeah, I feel like it's more in line with how we want people to create crawlers, when I tried to use the querySelector it felt clunky. I'll close this but we can revisit this later if there are some people using this context helper.

@B4nan B4nan closed this as completed Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janbuchar janbuchar

Labels
t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@janbuchar @B4nan