fix: notify autoscaled pool about newly added requests

[B4nan]

Notify AutoscaledPool when calling crawler.addRequests(). This is important for crawlers in keepAlive mode that might have an empty queue and we don't want to wait till the next scheduled check (which might come in as much as 500ms by default).

Related: https://apify.slack.com/archives/CD0SF6KD4/p1711660060498849

[github-actions]

⚠️ Pull Request Tookit has failed!

Pull request is neither linked to an issue or epic nor labeled as adhoc!

[vladfrangu]

Maybe we should make a public method that lets you manually trigger this? LGTM otherwise

[B4nan]

I actually had it like that initially, then I started writing the jsdoc, and I realized that the method will be called automatically from inside crawler.addRequests, so it's not really important for users. What other use cases would there be?

[vladfrangu]

I guess for now there isn't any I can think off the top of my head, maybe in the future when we make DB storages too and people manually alter DBs we can provide it (if needed)

[janbuchar]

I actually had it like that initially, then I started writing the jsdoc, and I realized that the method will be called automatically from inside crawler.addRequests, so it's not really important for users. What other use cases would there be?

If AutoscaledPool allows notifying it from the outside, it should be a part of its public API - calling a protected method from elsewhere seems like unnecessary smoke and mirrors. If anyone wants to use AutoscaledPool (I don't think many people do that), they should be able to handle the truth.

[B4nan]

If AutoscaledPool allows notifying it from the outside, it should be a part of its public API - calling a protected method from elsewhere seems like unnecessary smoke and mirrors.

I was afraid of this academic debate... :] You could say this about every single quirk we have in the code base (and there are many, including the autoscaled pool class itself, welcome to javascript :D).

Will add the public method, as I don't feel like arguing about such a small change. But I will be very surprised if anyone ever uses this method :]

[janbuchar]

I was afraid of this academic debate... :] You could say this about every single quirk we have in the code base (and there are many, including the autoscaled pool class itself, welcome to javascript :D).

Oh yes, yes I will.