feat: add iframe expansion to parseWithCheerio in browsers

[barjin]

Replaces the iframe elements with their contents in <div class="crawlee-iframe-replacement"></div> element.

Closes #2507

[janbuchar]

Do we really need to duplicate this function?

[barjin]

The thing is, @crawlee/playwright and @crawlee/puppeteer are separate packages, so we would have to create a new package for this shared code (any other crawlee package doesn't / cannot depend on playwright or puppeteer(?)).

I see that these two are verbatim copies, but that's only because here we're using the subsets of PW / PP interfaces that are equal... other utils methods are different for PW / PP. I like to think of these as "platform" specific ports of the same features.

[janbuchar]

Couldn't it be put in @crawlee/browser-crawler somehow?

[barjin]

Because of what I mentioned above, it would be very awkward - see here:

crawlee/packages/browser-crawler/src/internals/browser-crawler.ts

Lines 818 to 823 in 9918747

	export async function extractUrlsFromPage(
	// eslint-disable-next-line @typescript-eslint/ban-types
	page: { $$eval: Function },
	selector: string,
	baseUrl: string,
	): Promise<string[]> {

Or here:

crawlee/packages/browser-pool/src/abstract-classes/browser-plugin.ts

Lines 42 to 45 in 9918747

	export interface CommonPage {
	close(...args: unknown[]): Promise<unknown>;
	url(): string | Promise<string>;
	}

Dependency injection... or something, I guess.

With this as an alternative, I'm more than happy to have "duplicate" separate implementations for both libraries.

[janbuchar]

Hm, I guess you'd have to write quite a lot of boilerplate types. I guess I'm equally unhappy with both approaches.

[B4nan]

@crawlee/browser package has optional peer dependencies on both playwright and puppeteer, so you can surely have a code that works with both of them inside it. But to do that without hacks like ts-ignore comments and dynamic imports, you would need to introduce separate exports for each library that wouldn't be exported from the root index file. Probably not worth it now.

[B4nan]

lgtm, i am curious if this works with the iframe we have in crawlee docs (giscus) too