Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename OLinkClient to OLinkConn (or OLinkConnection) #36

Closed
jryannel opened this issue Aug 25, 2022 · 0 comments · Fixed by #45
Closed

Rename OLinkClient to OLinkConn (or OLinkConnection) #36

jryannel opened this issue Aug 25, 2022 · 0 comments · Fixed by #45

Comments

@jryannel
Copy link
Contributor

We talk often in terms of client and server, and a Client makes it an OlinkClient makes it different to differentiate between other clients (e.g. ClientNode).

So making sure it just manages the connection would make t more clear.

e.g. OLinkConnection.
@dorotaphanSiili dorotaphanSiili mentioned this issue Aug 30, 2022
Closed
@dorotaphanSiili dorotaphanSiili linked a pull request Aug 30, 2022 that will close this issue
Dphan/olink core refactor #41
Closed
2 tasks
@dorotaphanSiili dorotaphanSiili linked a pull request Oct 10, 2022 that will close this issue
Dphan/olink refactor server side #45
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@jryannel