New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRUP-728] Apigee Monetization for Kickstart #88
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazing work @arshad! I know there were many challenges here, so I appreciate the end result that much more. I've tested this a bunch of ways so far, and all have worked great, except for one, and I know this is still in progress, so I'll just log what I've tested so far.
Install via browser, skipping M10n option.
✅This worked as expected, which is to install the Kickstart in its current state (as if no m10n module exists). I also tried this with and without demo content.
Install via Drush, skipping M10n option.
✅This worked as expected (same as above). The argument to Drush is apigee_devportal_kickstart_configuration_form.op='Skip this step'
Install via browser, after removing m10n/commerce/address modules from the file system
✅ 🎉 👏 This is beyond expectations!!! The installer task doesn't even show up. Great job!
Install via Drush, after removing m10n/commerce/address modules from the file system
✅ Works as expected. Same as above.
Install with m10n
✅ Works as (really better than) expected. It's so nice to skip all the configuration that these modules require. I recorded a screencast for this, which I'll try to upload on Monday.
IMO, the Address issue can be dealt with in a follow up, as this is a massive improvement, and we can document the above issue in the meantime, so I'm approving this.
I just finished re-testing everything, and the address issue mentioned in my previous review is now resolved. The only improvement I would suggest is specifying in the field label, description that a code is wanted for the administrative area (usually State), CA vs California. There IS currently placeholder text that indicates this, but I never saw it during install, thanks to autofill. Or potentially handing this on the backend. We can make a ticket to address this later. Thanks again @arshad! Really great work here. 🥇 |
This PR adds an installation task to enable and configure Apigee Monetization for Kickstart.
During installation, if a user provides a valid Edge connection, we check if the configured organization has monetization enabled. If yes, the user can enable monetization for kickstart.
A form to configure a store and supported currencies is also provided during installation. The form is pre-populated with values from the Apigee API.
Note: the monetization task is optional and can be skipped. It is only available if the required modules apigee_m10n and dependencies are available.
This will automatically:
The only config left will be the payment gateway which we cannot configure automatically.
How to test this PR without Monetization modules:
git clone git@github.com:apigee/devportal-kickstart-project-composer.git kickstart
composer.json
and add the following patch:composer require apigee/apigee_devportal_kickstart:dev-8.x-1.x
This will pull in the latest kickstart with this PR.Run the installer. It should install the profile and not ask you about monetization.
How to test this PR with Monetization modules:
composer require drupal/apigee_m10n drupal/commerce
to pull in the monetization modules and dependencies.