Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Edge role creation script to module #210

Closed
cnovak opened this issue Jun 3, 2019 · 3 comments · Fixed by #230
Closed

Add Edge role creation script to module #210

cnovak opened this issue Jun 3, 2019 · 3 comments · Fixed by #230
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@cnovak
Copy link
Collaborator

cnovak commented Jun 3, 2019

Currently the module's documentation installation steps say to download a gist from my GitHub repo, which is weird. This should be instead a script in the module.

@cnovak cnovak added this to To do in Drupal-based Development Board via automation Jun 3, 2019
@mxr576
Copy link
Contributor

mxr576 commented Jun 4, 2019

Well, it definitely seems odd that a customer has to pull down a script from your GH repo and not from an official Apigee repo, so one obvious solution for this problem is to move the shell script to an official Apigee repo. What this script is needed for is only a one-time configuration.

IIRC I haven't seen any Drupal module yet that would ship a shell script as part of the module. Although it seems Drupal core's .htaccess could handle it, if you would like to move it to the module I would suggest to rewrite the shell script to a Drush/Drupal Console command.
Your shell script obviously only runs on Unix based OS-es and Windows 10 with WSL enabled and it requires curl, but it does not validate whether it is installed or not.
The Drush/Drupal console command could run on all OS-es and because ext-curl is a requirement of Drupal (also Guzzle 6 is available) you would not need to worry about dependency issues and you could simplify your script a lot.

@cnovak
Copy link
Collaborator Author

cnovak commented Jun 4, 2019

Good input @mxr576 , was thinking that it would be good to move to module and later move into Drush/Drupal console, but the OS dependency would be good to solve ASAP.

@mxr576
Copy link
Contributor

mxr576 commented Jun 5, 2019

Not sure how else you could solve the OS dependency than the suggested solution. Probably you could to create a CMD or Powershell version from your script, but if you invest time to that, why do not you rather invest time to the cross-platform Drush/Drupal console command instead?
If you do not have the capacity to write the hybrid Drush/Drupal console command just let me and @arunz6161 know and we'll figure something out.

@arunz6161 arunz6161 moved this from To do to In progress in Drupal-based Development Board Jun 17, 2019
@arunz6161 arunz6161 moved this from In progress to To do in Drupal-based Development Board Sep 4, 2019
@arunz6161 arunz6161 removed their assignment Sep 4, 2019
@cnovak cnovak moved this from To do to In progress in Drupal-based Development Board Oct 4, 2019
Drupal-based Development Board automation moved this from In progress to Done Dec 19, 2019
@cnovak cnovak added this to the 8.x-1.4 milestone Jan 7, 2020
@cnovak cnovak added the enhancement New feature or request label Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging a pull request may close this issue.

3 participants