This repository has been archived by the owner on Sep 2, 2022. It is now read-only.
Send request and response body size information with metrics #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruohola
changed the title
Also, replace the clunky EndBug/add-and-commit action simply with good old CLI Git usage. Was nice to get rid of clean-git-head.js as well.
ruohola
force-pushed
the
request-response-sizes
branch
from
a47bd99
to
fba9d5c
Compare
Codecov Report
@@ Coverage Diff @@
## master #14 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 59 68 +9
Branches 10 16 +6
=========================================
+ Hits 59 68 +9
Continue to review full report at Codecov.
|
Just have to rely on Content-Length headers here since there really didn't seem to be any other reliable way of getting request or response body sizes.
ruohola
force-pushed
the
request-response-sizes
branch
from
fba9d5c
to
2fa6cd8
Compare
blomqma
approved these changes
Feb 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just have to rely on Content-Length headers here since there really didn't seem to be any other reliable way of getting request or response body sizes.