Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag inappropriate or defunct APIs #1013

Closed
10 of 14 tasks
bajiat opened this issue Jun 1, 2016 · 10 comments
Closed
10 of 14 tasks

Flag inappropriate or defunct APIs #1013

bajiat opened this issue Jun 1, 2016 · 10 comments
Assignees
Milestone

Comments

@bajiat
Copy link
Contributor

bajiat commented Jun 1, 2016

User story

As an Apinf administrator I want to flag inapproprite or defunct APIs so that it becomes possible to exclude or filter out these APIs

Definition of done

Collection

  • Collection exists for flags
    • Contains flag reason: inappropriate, defunct
    • Contains a text field for description or comment
    • Contains reference field for user id (which admin flagged the API)
    • foreign key to the API backend getting flagged
  • if the api is unflagged by admin, the information gets updated to db

UI component

  • UI component for flagging (opens dialog)
  • Modal dialog for adding the flag
  • Modal dialog contains an option to unflag

User permissions

  • Only administrator can flag
    • Only administrator can view the UI component and the dialog
    • Only administrator can insert anything to the collection
    • Only administrator can unflag

Outcome

  • Flagged API is not visible in catalog (Update: decided to keep this open until the new version of api catalogue list is implemented)
@brylie
Copy link
Contributor

brylie commented Jun 6, 2016

@frenchbread are you interested in taking this task?

@frenchbread frenchbread self-assigned this Jun 6, 2016
@frenchbread
Copy link
Contributor

Self-assigned

@frenchbread frenchbread added ready and removed planning labels Jun 6, 2016
@philippeluickx
Copy link
Contributor

Are there related tickets to this? There are a couple of interesting use cases:

  • Optional description field (why does user flag this API)
  • alert (email) the API owner when someone flags
  • Use flags in scoring when ranking APIs
  • Display flagged APIs in the dashboard for API owners

Also some concerns: let's say my server went down for 1h and some people flagged the API. Now I relaunched the server and made sure this won't happen anymore. But the flags still have an impact? It's a bit unforgiving...

@brylie
Copy link
Contributor

brylie commented Jun 8, 2016

@bajiat lets work on the definition of done for this task with @frenchbread

@frenchbread frenchbread added this to the Sprint 24 milestone Jun 8, 2016
@bajiat
Copy link
Contributor Author

bajiat commented Jun 8, 2016

@philippeluickx Good questions. We have another issue for crowdsourcing where these questions will come even more critical. I'll add the issue link later. This ticket is for the administrative usage only.

@philippeluickx
Copy link
Contributor

Ok, thanks for the clarification. I got confused because the flagging showed up in some of the mockups.

@bajiat
Copy link
Contributor Author

bajiat commented Jun 8, 2016

Your comments will be good enhancements for both this task and the crowdsourced flagging,

@bajiat
Copy link
Contributor Author

bajiat commented Jun 8, 2016

@frenchbread Please check the definition of done. Is your estimate still valid?

@frenchbread
Copy link
Contributor

@bajiat Yes.

@bajiat
Copy link
Contributor Author

bajiat commented Jun 9, 2016

@philippeluickx Here is the link to the issue, where flagging could be done by community: #1014

@55 55 closed this as completed in #1085 Jun 9, 2016
@55 55 removed the in progress label Jun 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants