Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor dashboard code #1040

Closed
2 of 5 tasks
frenchbread opened this issue Jun 6, 2016 · 4 comments
Closed
2 of 5 tasks

Refactor dashboard code #1040

frenchbread opened this issue Jun 6, 2016 · 4 comments
Assignees

Comments

@frenchbread
Copy link
Contributor

frenchbread commented Jun 6, 2016

As an Apinf developer I want to easily reuse functions that are used there.

  • Refactor code to be more easy to read and maintain.
  • If the logic architecture allows it, try to make code more object oriented

Since this is not creating any new functionality, but rather improving existing one, do not spend more than 1 hour on this task.

Definition of done

  • Dashboard contains no functions with subfunctions
  • If possible, dashboard functions are objects with methods
  • Most or all of ElasticSearch variables are parametrized
  • Code is easy to read
  • Code contains comments
@brylie
Copy link
Contributor

brylie commented Jun 6, 2016

@frenchbread is this a work in progress or should we wait for the Dashboard sprint?

@frenchbread
Copy link
Contributor Author

@brylie It's not in progress, so let's take this issue to the dashboard sprint.

@frenchbread
Copy link
Contributor Author

frenchbread commented Jun 27, 2016

Testing out refactored version of updated dashboard in this repo.

Still having two issues:

  • Data fetch takes too much time (even though it has been optimized)
  • "Average response time" chart does not work

@brylie
Copy link
Contributor

brylie commented Jun 30, 2016

@frenchbread tried an approach where we stored analytics in the MongoDB instance, but the performance was slow when serving > 10,000 records:

apinfdashboardbenchmark

We decided to revert to using the Meteor server to relay the Elastic analytics data. This isn't 'perfect', but it seems to improve the situation we are trying to solve (issue #1105).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants