Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-initialize apiUmbrellaWeb instance when API Umbrella settings change #1104

Closed
brylie opened this issue Jun 9, 2016 · 1 comment
Closed

Re-initialize apiUmbrellaWeb instance when API Umbrella settings change #1104

brylie opened this issue Jun 9, 2016 · 1 comment
Assignees
@brylie
Labels
bug
Milestone
Sprint 24

Comments

@brylie
Copy link
Contributor

brylie commented Jun 9, 2016 •
edited

The apiUmbrellaWeb object is not being re-initialized when settings change. This means, that any errors in configuration remain even after updating the configuration page.
@brylie brylie added the bug label Jun 9, 2016
@brylie brylie mentioned this issue Jun 9, 2016
Merged
@brylie brylie self-assigned this Jun 9, 2016
@brylie
Copy link
Contributor Author

brylie commented Jun 10, 2016

An alternative approach would be to initialize the apiUmbrellaWeb inside of any server method where it is used. This would avoid having to manage a global apiUmbrellaWeb object.

@brylie brylie added this to the Sprint 24 milestone Jun 10, 2016
@jykae jykae removed the in progress label Jun 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brylie brylie

Labels
bug
Projects
None yet
Milestone
Sprint 24
Development

No branches or pull requests
2 participants
@brylie @jykae