Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Documentation modal closes when submitting invalid URL #1403

Closed
brylie opened this issue Aug 17, 2016 · 4 comments
Closed

API Documentation modal closes when submitting invalid URL #1403

brylie opened this issue Aug 17, 2016 · 4 comments
Assignees
Labels

Comments

@brylie
Copy link
Contributor

brylie commented Aug 17, 2016

When editing the documentation for a given API, the modal dialogue can be closed when the URL is invalid. The autoform/schema will reject the invalid URL, so the change does not get saved to the database. This creates an inconsistent experience for the user, since they do not see the validation error and are left to scratch their head.

@ilarimikkonen
Copy link
Member

for 0.58

@ilarimikkonen
Copy link
Member

2.PNG

@matleppa
Copy link
Member

matleppa commented Jan 10, 2019

It is hard to prevent the modal closing, so we can add a error text, which updates when the API document address is typed into the input field.
This way the user sees, when the URL is formally correct and expected to be added into database.

@matleppa
Copy link
Member

There is a alight usability problem:
When URL is typed in, the autofill shows drop-down menu, if suitable values exist.
This menu covers the error message.
One solution might be adding the error message above the input field.
However, the afQuickField element in autoform shows the error message below input field as default. If a change were needed, the functionality needs to be implemented instead of default functionality.

And the common look-and-feel would be lost.

@ghost ghost removed the in progress label Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants