Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor project files for consistency #1444

Closed
brylie opened this issue Aug 26, 2016 · 3 comments
Closed

Refactor project files for consistency #1444

brylie opened this issue Aug 26, 2016 · 3 comments
Assignees
Milestone

Comments

@brylie
Copy link
Contributor

brylie commented Aug 26, 2016

Audit all project router.js files so they follow the same pattern:

  • each router file is located in a component
  • each component router file contains routes only for the component
  • component router files are in the /component/client/lib/router.js file
  • router onBefore or other hooks are either in core, or in the specific router file where they are used

Additionally, refactor the Settings component into several separate components. Based on discussion with @brylie and @frenchbread.

@brylie
Copy link
Contributor Author

brylie commented Aug 30, 2016

@jykae thanks for going beyond the definition of done here. As per our discussion, and approval from @bajiat, please refactor the settings component into separate components, with the following structure:

  • /branding
    • /logo
  • /settings
    • /client
      • /menu
  • /proxies
  • /users
    • /account
    • /profile

@frenchbread and @NNN, please be aware that @jykae will be moving these files around, so that you have as few conflicts as possible.

@brylie
Copy link
Contributor Author

brylie commented Aug 30, 2016

Also note, this should not affect the user interface. It is just a code-level refactor. We want to keep the great work on the settings page, including the navigation menu.

@jykae
Copy link
Contributor

jykae commented Aug 30, 2016

@brylie Ok, did not notice to check out this issue, was following PR. I make further changes based on your comments & our discussion.

@brylie brylie changed the title Refactor project router files for consistency Refactor project files for consistency Aug 30, 2016
@brylie brylie added this to the Sprint 30 milestone Aug 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants