-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Swagger viewer as npm module #1476
Comments
@brylie Add links to potential npm packages |
@bajiat @marla-singer Please see the Candidate npm packages section in the issue description. @marla-singer feel free to do any research and offer alternative proposals to how we can integrate Swagger UI into our templates without using iframe. |
@brylie Thanks! |
@brylie Thank you! Has this task any deadline? |
@marla-singer Can you give us your estimate on how long it would take? How many days? |
@bajiat Today I'm going to study the task more detail and I'll be able give my estimate tomorrow. |
@marla-singer Sounds good to me. |
@marla-singer I removed part of the definition of done. (I thought I had removed it before, but that change didn't actually get updated to Github). The removed part will be in another continuation task. Without removing, your task would be partially blocked by another developer's task. Also, it is best to approach this incrementally. |
@bajiat Yesterday and today I learnt npm packages and tryed to implement swagger-ui packages in empty meteor project. So I think it needs about 2 days to integrate and setting swagger library to our project plus a day for test and review. My estimate is three days. |
@marla-singer Thanks for the estimate! What is the current status of the task? |
@bajiat Current status is setting of css and fix to show button 'Authorize' |
#1490 @marla-singer Is it possible to control Swagger UI launch settings while starting? |
@preriasusi we can invoke Swagger UI with several parameters. Which settings do we need to control? |
@preriasusi Yea, I think it's possible. |
For clarification, this task takes us in the direction of being able to use Swagger UI parameters, rather than the iframe, by using an npm module. We can follow-up with enhancement tasks based on the Swagger UI configuration parameters, etc. |
Swagger Viewer is currently displayed in iFrame. The solution is very brittle and for example inserting base URL and user's API for making calls through apinf would require a hacky implementation.
The iFrame solution should be replaced by implementing Swagger viewer as npm module.
Definition of done
Candidate npm packages
Example of integrating Swagger UI into templating languages
The text was updated successfully, but these errors were encountered: