Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Swagger viewer as npm module #1476

Closed
5 tasks
bajiat opened this issue Sep 1, 2016 · 15 comments
Closed
5 tasks

Implement Swagger viewer as npm module #1476

bajiat opened this issue Sep 1, 2016 · 15 comments
Assignees

Comments

@bajiat
Copy link
Contributor

bajiat commented Sep 1, 2016

Swagger Viewer is currently displayed in iFrame. The solution is very brittle and for example inserting base URL and user's API for making calls through apinf would require a hacky implementation.

The iFrame solution should be replaced by implementing Swagger viewer as npm module.

Definition of done

  • Suitable, actively maintained npm package for Swagger UI has been selected
  • Package has been integrated into Apinf
  • Swagger viewer module is displayed in the same place as the current iFrame solution
  • Swagger viewer is only displayed in documentation tab, if a Swagger file has been uploaded for that particular API
  • Swagger viewer displays the Swagger file that has been uploaded for the particular API

Candidate npm packages

Example of integrating Swagger UI into templating languages

@bajiat
Copy link
Contributor Author

bajiat commented Sep 1, 2016

@brylie Add links to potential npm packages

@brylie
Copy link
Contributor

brylie commented Sep 1, 2016

@bajiat @marla-singer Please see the Candidate npm packages section in the issue description.

@marla-singer feel free to do any research and offer alternative proposals to how we can integrate Swagger UI into our templates without using iframe.

@bajiat
Copy link
Contributor Author

bajiat commented Sep 1, 2016

@brylie Thanks!

@marla-singer
Copy link
Contributor

@brylie Thank you! Has this task any deadline?

@bajiat
Copy link
Contributor Author

bajiat commented Sep 1, 2016

@marla-singer Can you give us your estimate on how long it would take? How many days?

@marla-singer
Copy link
Contributor

@bajiat Today I'm going to study the task more detail and I'll be able give my estimate tomorrow.

@bajiat
Copy link
Contributor Author

bajiat commented Sep 1, 2016

@marla-singer Sounds good to me.

@bajiat
Copy link
Contributor Author

bajiat commented Sep 1, 2016

@marla-singer I removed part of the definition of done. (I thought I had removed it before, but that change didn't actually get updated to Github). The removed part will be in another continuation task. Without removing, your task would be partially blocked by another developer's task. Also, it is best to approach this incrementally.

@marla-singer
Copy link
Contributor

@bajiat Yesterday and today I learnt npm packages and tryed to implement swagger-ui packages in empty meteor project. So I think it needs about 2 days to integrate and setting swagger library to our project plus a day for test and review. My estimate is three days.

@bajiat
Copy link
Contributor Author

bajiat commented Sep 5, 2016

@marla-singer Thanks for the estimate! What is the current status of the task?

@marla-singer
Copy link
Contributor

@bajiat Current status is setting of css and fix to show button 'Authorize'

@preriasusi
Copy link
Contributor

#1490 @marla-singer Is it possible to control Swagger UI launch settings while starting?

@brylie
Copy link
Contributor

brylie commented Sep 6, 2016

@preriasusi we can invoke Swagger UI with several parameters. Which settings do we need to control?

@marla-singer
Copy link
Contributor

@preriasusi Yea, I think it's possible.

@brylie
Copy link
Contributor

brylie commented Sep 6, 2016

For clarification, this task takes us in the direction of being able to use Swagger UI parameters, rather than the iframe, by using an npm module.

We can follow-up with enhancement tasks based on the Swagger UI configuration parameters, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants