Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dashboard Select API list #1479

Closed
3 tasks done
bajiat opened this issue Sep 2, 2016 · 7 comments
Closed
3 tasks done

Update Dashboard Select API list #1479

bajiat opened this issue Sep 2, 2016 · 7 comments
Assignees
Milestone

Comments

@bajiat
Copy link
Contributor

bajiat commented Sep 2, 2016

Update the Dashboard Select API list so that it contains only APIs connected to a proxy.

Definition of done

  • APIs list contains only APIs connected to a proxy
    • API manager can see all APIs owned by him/her that are connected to a proxy. Optionally, the ones that are not connected to a proxy can be listed, but it should not be possible to select them.
    • Apinf admin can see all APIs connected to a proxy in the platform.
@bajiat bajiat added the ready label Sep 2, 2016
@bajiat bajiat changed the title Update API list Update Dashboard Select API list Sep 2, 2016
@bajiat
Copy link
Contributor Author

bajiat commented Sep 9, 2016

@frenchbread Would you be able to finish this before the new sprint starts or should I move this to planning column for sprint 31?

@frenchbread
Copy link
Contributor

@bajiat Please move this task to planning column for sprint 31.

@frenchbread
Copy link
Contributor

Interested

@bajiat bajiat added this to the Sprint 31 milestone Sep 12, 2016
@bajiat bajiat added ready and removed planning labels Sep 13, 2016
@bajiat
Copy link
Contributor Author

bajiat commented Sep 14, 2016

@frenchbread This issue seems to be in progress, but does not have any PR associated to it. Can you inform us about the status? Thanks!

@frenchbread
Copy link
Contributor

frenchbread commented Sep 14, 2016

@bajiat I have not pushed the changes yet.

Simply populate APIs to selecbox did not work, since proxyBackends (endpoint data) do not have helpers for permission check attached. So it's open question how to do that? (Fetching related API backend and checking permissions by created_by field?)

Also what URL should be used for API calls? I've tried the old way (https://<host>/api-umbrella/<frontend-prefix>?api_key=<api_key>) to generate sample analytics data, and did not get any response.

Ping @brylie

@brylie
Copy link
Contributor

brylie commented Sep 15, 2016

proxyBackends (endpoint data) do not have helpers for permission check attached.

We can rely on the Apis.currentUserCanEdit() helper for the permissions check. In effect, a proxy backend seems to share the permissions with the API, so we don't need to duplicate the code.

@brylie
Copy link
Contributor

brylie commented Sep 15, 2016

hat URL should be used for API calls? I've tried the old way (https:///api-umbrella/?api_key=<api_key>), and did not get any response.

You will still make calls to the same URL pattern.

The problem may be that the API Backend has not been added to API Umbrella. As it stands, 'ProxyBackends' are currently only stored in Apinf, with work planned to also save them in API Umbrella.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants