Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visibility of API that is private for a user group #1624

Closed
4 tasks done
bajiat opened this issue Sep 23, 2016 · 3 comments
Closed
4 tasks done

Visibility of API that is private for a user group #1624

bajiat opened this issue Sep 23, 2016 · 3 comments
Assignees
Milestone

Comments

@bajiat
Copy link
Contributor

bajiat commented Sep 23, 2016

Definition of done

  • If the API is visible to a group, only those people can
    • see the API in the catalog
    • see the API profile page
  • If an unauthorized user has the direct link to the API profile, they must see a 403 .

Wireframe

  1. API Catalog Card View
    apicatalogprivate
  2. API Catalog table View
    apicatalogtableprivate

In both cases, Users having access to Private API should be able to see them in API Catalog.
Respective Card & Table will contain a tag named Private.
Public APIs should not have any tags

  1. API profile view
    apiprofileprivate

    Tag should appear beside API name.
    Should be larger in size than card/table view

@Nazarah
Copy link
Contributor

Nazarah commented Oct 3, 2016

@jykae : i have added the wireframes.
You can use BS tag components to implement this.
Explanations are given in the wireframe section.
http://v4-alpha.getbootstrap.com/components/tag/

@jykae
Copy link
Contributor

jykae commented Oct 5, 2016

@Nazarah otherwise nice idea but we are not in v4-alpha, in our version it is still called label, http://getbootstrap.com/components/#labels

it looks the same so I use that

@jykae
Copy link
Contributor

jykae commented Oct 6, 2016

@bajiat Description is a bit mixing concepts between 401 & 403 http://stackoverflow.com/questions/3297048/403-forbidden-vs-401-unauthorized-http-responses

I think 403 is appropriate for this, unauthorized is a bit different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants