Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users allowed to submit incomplete 'Add API' form #1668

Closed
saralavanip opened this issue Sep 30, 2016 · 1 comment
Closed

Users allowed to submit incomplete 'Add API' form #1668

saralavanip opened this issue Sep 30, 2016 · 1 comment
Assignees
Labels

Comments

@saralavanip
Copy link
Contributor

saralavanip commented Sep 30, 2016

Steps:
1.Visit https://nightly.apinf.io
2.Create account clicking on Signup
3.Go to API Backends
4.Click on 'Add API Backend'
5.Enter Details:

  • Enter API name
  • Do not enter 'Description' (empty field)
  • Do not enter URL

6.Click on 'Add API' button

Findings:

  • Successful in adding API without filling 'Description' and 'URL fields'
  • Users not notified if fields empty
@brylie
Copy link
Contributor

brylie commented Sep 30, 2016

After discussing with @saralavanip and @bajiat, we decided to make the URL field mandatory. This has been done in commit ac2b686

@bajiat bajiat changed the title Users allowed to submit incomplete 'Add API' form Users allowed to submit incomplete 'Add API' form Sep 30, 2016
@brylie brylie self-assigned this Oct 3, 2016
@55 55 closed this as completed in #1677 Oct 3, 2016
@55 55 removed the in progress label Oct 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants