Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted account displays its related APIs in Catalog #1815

Closed
saralavanip opened this issue Oct 25, 2016 · 7 comments
Closed

Deleted account displays its related APIs in Catalog #1815

saralavanip opened this issue Oct 25, 2016 · 7 comments
Labels

Comments

@saralavanip
Copy link
Contributor

saralavanip commented Oct 25, 2016

Steps

  1. Visit https://nightly.apinf.io
  2. Sign up
  3. Add API with proxy
  4. Go to 'Account' page and click on 'Delete'
  5. Confirm 'delete account' by clicking on 'Delete' button
  6. Go to Catalog view

Findings

  • User not notified about successful 'Delete account'
  • Deleted account still displays its associated API in 'Catalog' and 'Latest APIs' list
  • Anonymous users can still view details and documentation of APIs associated with this deleted account.

Expected Result

  • Deleted account must notify user with successful message
  • It should also remove all its associated APIs from 'Catalog' and 'Latest APIs' list

Browser

  1. Mozilla Firefox 48.0
  2. Google Chrome 52.0.2743.116

Operating System

Ubuntu 16.0 LTS

@marla-singer
Copy link
Contributor

marla-singer commented Oct 25, 2016

Also these API, which has owner with deleted account, has owner admin

@bajiat bajiat changed the title Deleted account displays its related APIs in Catalog Deleted account displays its related APIs in Catalog Oct 25, 2016
@bajiat bajiat added the backlog label Oct 25, 2016
@marla-singer
Copy link
Contributor

marla-singer commented Oct 26, 2016

@bajiat Notification about successful deletion has already done, #1787 issue
And what we do with APIs, which owner was deleted? Should we save these apis or not? Now notification doesn't have any word about "... all your apis data will be removed". There are "There's no coming back from this one" and "Are you sure you want to delete your account?"

@bajiat
Copy link
Contributor

bajiat commented Oct 26, 2016

@marla-singer @saralavanip I don't think we can automatically delete the APIs when the account is deleted. Someone else might be relying on them and using them. But I don't have a good answer on who should be mentioned as 'added by' in the catalog in that case. The only one who can manage those APIs are admin.

This is a really interesting case because we allow adding any APIs and you don't literally have to be their owner. We are not asking for proof of owning the APIs.

@marla-singer
Copy link
Contributor

marla-singer commented Oct 26, 2016

@bajiat Agree with you over all. So what do you think about adding the additional filter in Catalog or something else for Apinf Administrator, which will show the APIs without owner?

@bajiat
Copy link
Contributor

bajiat commented Oct 26, 2016

@brylie suggested adding a new flag 'orphan' as first step.

@bajiat
Copy link
Contributor

bajiat commented Oct 26, 2016

Added issue #1821.

@bajiat
Copy link
Contributor

bajiat commented Oct 27, 2016

Closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants